[LLVMdev] Botched Build

[David Greene]

On Monday 15 February 2010 15:27:34 Chris Lattner wrote:
> On Feb 15, 2010, at 1:17 PM, David Greene wrote:
> > On Monday 15 February 2010 15:08:22 Chris Lattner wrote:
> >> On Feb 15, 2010, at 1:04 PM, David Greene wrote:
> >>>> FWIW, this is because you broke the encoding of an instruction in your
> >>>> patch.  This is incorrect:
> >>>>
> >>>> +def MOVNTDQ_64mr : PSI<0xE7, MRMDestMem, (outs), (ins f128mem:$dst,
> >>>> VR128:$src), +                    "movntdq\t{$src, $dst|$dst, $src}",
> >>>> +                    [(alignednontemporalstore (v2f64 VR128:$src),
> >>>> addr:$dst)]>;
> >>>>
> >>>> Please don't check in patches when you know that they break testcases.
> >>>
> >>> I certainly didn't know it broke anything.  I even checked the buildbot
> >>> and it looked like it failed before I ever applied anything.  Apologies
> >>> for the mix- up.
> >>
> >> FYI, if you want to check the encoding of an instruction, you can do so
> >> with a command like this:
> >
> > Thanks.  It's strange that the buidbot shows this test failing long
> > before I made the change.  Why would that be?
>
> It didn't.  Here's a good build:
> http://smooshlab.apple.com:8010/builders/clang-i386-darwin9/builds/5019

Well, I can't get there, but...

Oh.  Buildbot is not displaying what I would expect.  Looking at the Console 
(revision-oriented) Display, I was looking for errors listed under the color-
keyed build results.  For example:

clang-i386-auroraux : compile Debug failed. [ stdio ]
 clang-x86_64-darwin10-selfhost : test llvm 4558 tests 4557 passed 25 warnings 
1 failed failed. [ stdio fail xfail unsupported multiplepluginpriorities.td ]

I was seeing the same failure (x86_32-ecoding.s) listed everywhere.  I would 
expect that these errors show the results of the build of the revision but 
apparently it simply shows the global results of the latest build.

I don't know if that's intended of it it's a buildbot bug but it's certainly 
not what I would expect.

> > As for documentation, where should that go in LangRef.html?  There's
> > nothing there yet that really talks about special metadata.  I can make
> > up a section if that seems appropriate.
>
> Add it to the #i_store section, thanks.

Ok.  This can also affect loads too so I'll add something for that too.

                                         -Dave