[LLVMdev] Botched Build

[Chris Lattner]

On Feb 15, 2010, at 1:27 PM, Chris Lattner wrote:

> 
> On Feb 15, 2010, at 1:17 PM, David Greene wrote:
> 
>> On Monday 15 February 2010 15:08:22 Chris Lattner wrote:
>>> On Feb 15, 2010, at 1:04 PM, David Greene wrote:
>>>>> FWIW, this is because you broke the encoding of an instruction in your
>>>>> patch.  This is incorrect:
>>>>> 
>>>>> +def MOVNTDQ_64mr : PSI<0xE7, MRMDestMem, (outs), (ins f128mem:$dst,
>>>>> VR128:$src), +                    "movntdq\t{$src, $dst|$dst, $src}",
>>>>> +                    [(alignednontemporalstore (v2f64 VR128:$src),
>>>>> addr:$dst)]>;
>>>>> 
>>>>> Please don't check in patches when you know that they break testcases.
>>>> 
>>>> I certainly didn't know it broke anything.  I even checked the buildbot
>>>> and it looked like it failed before I ever applied anything.  Apologies
>>>> for the mix- up.
>>> 
>>> FYI, if you want to check the encoding of an instruction, you can do so
>>> with a command like this:
>> 
>> Thanks.  It's strange that the buidbot shows this test failing long before I
>> made the change.  Why would that be?
> 
> It didn't.  Here's a good build:
> http://smooshlab.apple.com:8010/builders/clang-i386-darwin9/builds/5019
> 
> The following two builds are broken by your previous bug:
> http://smooshlab.apple.com:8010/builders/clang-i386-darwin9/builds/5020
> http://smooshlab.apple.com:8010/builders/clang-i386-darwin9/builds/5021
> 
> with that fixed, the subsequent builds failed these regression tests:
> http://smooshlab.apple.com:8010/builders/clang-i386-darwin9/builds/5022 

Sorry, I just realized that those are from the internal builder, the external ones are similar, just different links.

-Chris