[LLVMdev] PR4882

[Chris Lattner]

On Sep 7, 2009, at 1:49 PM, Jakub Staszak wrote:

>
> On Sep 7, 2009, at 5:02 PM, Duncan Sands wrote:
>
>> Hi Jakub, looks good.
>>
>>> +  LLVMContext *Context = &SI->getContext();
>>
>> I guess this could be
>> LLVMContext &Context = SI->getContext();
>> which means you can use Context rather than *Context below.
>
> Right, C bad habit ;) Fixed.
>
>>> -      const Type *Ty = Type::getInt64Ty(SI->getContext());
>>> -      MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset,  
>>> &Ty, 1);
>>> +      const Type *Tys[] = {Type::getInt64Ty(*Context)};
>>> +      MemSetF = Intrinsic::getDeclaration(M, Intrinsic::memset,
>>> +                                          Tys, 1);
>>
>> Why did you introduce Tys and not stick with Ty?
>
> Ah, I did "svn update" after my correction and I didn't notice that.  
> Fixed.
>
> I also added "-disable-output" to test-case.

Thanks!  I hand minimized the testcase a bit, applied as r81175.

-Chris