[LLVMdev] [PATCH] Support asm comment output

Chris Lattner clattner at apple.com
Mon Jul 13 11:05:04 PDT 2009

On Jul 13, 2009, at 10:07 AM, David Greene wrote:

> On Sunday 12 July 2009 18:56, Chris Lattner wrote:
>> A couple of things are important to discuss:
>> +    dynamic_cast<formatted_raw_ostream &>(O) << Comment(*c);
>> We're trying to eliminate rtti, please don't add new uses of it.
>> Switching all of the asmprinter to statically use
>> formatted_raw_ostream would be appropriate.
> To separate comments, would it be ok to commit this bit as-is and  
> follow
> it up with making the change to static formatted_raw_ostream?

Yep, I'm fine with it being that way temporarily, please don't add the  
comments vector to MachineInstr though.


More information about the llvm-dev mailing list