[LLVMdev] [PATCH] Support asm comment output
David Greene
dag at cray.com
Mon Jul 13 10:07:00 PDT 2009
On Sunday 12 July 2009 18:56, Chris Lattner wrote:
> A couple of things are important to discuss:
>
> + dynamic_cast<formatted_raw_ostream &>(O) << Comment(*c);
>
> We're trying to eliminate rtti, please don't add new uses of it.
> Switching all of the asmprinter to statically use
> formatted_raw_ostream would be appropriate.
To separate comments, would it be ok to commit this bit as-is and follow
it up with making the change to static formatted_raw_ostream?
-Dave
More information about the llvm-dev
mailing list