[LLVMdev] [llvm-commits] [llvm-gcc-4.2] r61493 - in /llvm-gcc-4.2/trunk/gcc: ipa-inline.c passes.c

[Dale Johannesen]

On Dec 30, 2008, at 5:15 AMPST, Duncan Sands wrote:

> Author: baldrick
> Date: Tue Dec 30 07:15:15 2008
> New Revision: 61493
>
> URL: http://llvm.org/viewvc/llvm-project?rev=61493&view=rev
> Log:
> Now that LLVM handles always_inline itself, run
> gcc's early inliner rather than the full inliner.
> This does a lot less inlining, and partially
> fixes PR3232.  On the other hand, this may cause
> regressions with webkit and friends (PR2353),
> but there's only one way to find out!

This causes a regression of approximately 10% when cpp is built with  
llvm-gcc.

I'm not sure what the criteria for putting this in should be; maybe we  
should discuss that before you try again.  I don't think "no  
regressions on anything" is reasonable; the compiler doesn't have  
enough information to do a perfect job of inlining, so some things are  
inevitably going to regress.  I do think cpp is one of the things that  
shouldn't regress, though.