[LLVMdev] Unit test patch, updated

[Misha Brukman]

2008/12/30 Talin <viridia at gmail.com>

> OK changes made and new patch attached.
>

I'm not sure how I missed this the first time, or if it's new:

+++ unittests/TestMain.cpp    (revision 0)
+//===--- TestMail.cpp - unittest driver
-----------------------------------===//

Same comment as previously. :-)


> On Tue, Dec 30, 2008 at 2:40 PM, Misha Brukman <brukman at gmail.com> wrote:
>
>> 2008/12/30 Misha Brukman <brukman at gmail.com>
>>
>>> 2008/12/30 Talin <viridia at gmail.com>
>>>
>>>> Some notes on the patch:
>>>>
>>>>    - This patch doesn't include googletest itself, that will need to be
>>>>    checked in separately. The source distribution will live in
>>>>    llvm/utils/unittest/googletest. (The reason for the extra directory level is
>>>>    so that the LLVM-specific makefiles can live in llvm/utils/unittest, while
>>>>    the googletest directory itself can be the pristine, unmodified
>>>>    distribution.)
>>>>
>>>> Are you going to send a separate patch for this, or should I do this?
>>>
>>
> Please go ahead and do this. It seems silly (to me anyway) to convert the
> source tarball into a patch file.
>

Yes, I figured this out after trying to see what's involved there.  I'm
thinking we don't need to keep everything in the tarball, because it'll just
bloat the LLVM distribution.  I think we should be fine with just the
include/ and src/ directories, and I'll keep the COPYING file since it's the
license, and add a README.LLVM file.  Sound good?

>
>>>>    -
>>>>    - The individual tests are in llvm/unittests (note plural).
>>>>    - The makefile target to build and run the tests is "make unittest"
>>>>    (I wasn't sure if you could have a synthetic target that was the same as the
>>>>    name of a directory, so I made it "unittest" instead of "unittests")
>>>>
>>>> I don't think that's an issue -- to recurse into a directory, you have
>>> to say "make -C dir [target]".
>>>
>>
So can we call the target to build and run unittests "unittests" or does it
create problems?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20081230/0abb6108/attachment.html>