[LLVMdev] Inline hints for *compiler clients*

[Chris Lattner]

On Wed, 15 Mar 2006, Vikram S. Adve wrote:
>> I would like the list of functions excluded from inlining to be specified 
>> on the command line (as I'm using the LLVM opt command); providing a 
>> constructor to the Inliner pass that takes a list of function names to 
>> exclude from inlining might also be handy to LLVM programmers but is beyond 
>> what I need at the moment.
>
> That seems fine.  I just think a more general mechanism that does not have 
> greater complexity is better than a narrower one.  In this case, replacing 
> the constants with a lookup table that can be modified by any tool seems like 
> a simple and general way to implement your option, or the constructor for the 
> Inliner pass, or more sophisticated tools.

You're ignoring the cost and complexity of implementing this, it is not as 
simple as you claim.

>> I think Chris indicated in an earlier email that such a command line option 
>> is now okay.  Chris, please let me know if I understand that correctly.
>> 
>> The ability to control inlining from the source code being compiled (i.e. 
>> GCC's noinline attribute), adjust the inlining heuristics programmatically 
>> from a custom built LLVM tool, etc, are beyond the scope of what I need.
>
> The former is certainly much more complicated.  The latter (controlling 
> heuristics from an LLVM tool) does not seem to be significantly more 
> complicated.

Huh?

-Chris

-- 
http://nondot.org/sabre/
http://llvm.org/