[LLVMdev] Fixes for windows version

Reid Spencer reid at x10sys.com
Mon Nov 15 23:04:32 PST 2004


Jeff,


On Mon, 2004-11-15 at 21:43, Jeff Cohen wrote:
> I have some patches of my own:
> 
> * An improvement on Morten's fix to Signals.cpp.
> 
> * Undo the breakage to system.vcproj (Signals.cpp was being built twice
>   as a result).
> 
> * Fix a class/struct inconsistency.
> 
> * Remove unneeded #includes from win32 fSystem files.
> 

Thanks for the excellent patches. All commited.

> I've also determined why VC++ complains about deprecated destructors
> when using hash_map.  Because it's not ANSI (yet), Microsoft decided to
> move it from the std namespace to the stdext namespace.  Use of
> std::hash_map is therefore deprecated.  Similar shenanigans have been
> committed by gcc from one version to another.  I see where this is
> handled (llvm/ADT/hash_map), but it isn't clear how to add support for
> VC++ to the auto config magic.

Yeah, there's tests in autoconf/m4/cxx_hash_map to dictate which naming
style needs to be used. You'll have to haxor it in there if you're not
using the configure script.

> 
> I'll soon thoroughly go through the llvm_test results for FreeBSD to
> identify all platform dependencies that cause failures.  I'm getting far
> more failures than I have in the past, though it's apparent many tests
> have also been added.  Perhaps they never passed?

There's only a handful (8-10) that don't pass at this point. See the
nightly test results for other platforms for the  details:

 http://llvm.cs.uiuc.edu/testresults/

Reid.

> 
> On Mon, 15 Nov 2004 09:29:15 -0800
> Reid Spencer <reid at x10sys.com> wrote:
> 
> > Morten,
> > 
> > I've applied these patches. Thanks for the updates!
> > 
> > Reid.
> > 
> > On Mon, 2004-11-15 at 01:26, Morten Ofstad wrote:
> > > Hi,
> > > 
> > > when I updated the sources today there were several small problems that 
> > > stopped the windows version from compiling, here are the patches
> > > 
> > > m.
> 
> ______________________________________________________________________
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20041115/678db2f9/attachment.sig>


More information about the llvm-dev mailing list