[LLVMdev] Compiling with Intel c++ 8.0

[Chris Lattner]

On Wed, 8 Dec 2004, [iso-8859-1] Bjørn Wennberg wrote:

> I am attempting to compile the llvm distribution with the Intel Compiler 8.0
> on linux and I have some minor patches I would like to apply. In our project
> we compile and run the code both on win32, together with Morten Ofstad using
> the MS compiler, and on linux using the intel compiler.

Great!  I'm going to leave the configury stuff to Reid, but here's some 
feedback on the rest of the patches.  I've committed a bunch of them:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041206/021867.html
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041206/021868.html
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041206/021869.html
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041206/021870.html
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041206/021872.html
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20041206/021873.html

However, could you explain why there hunks are needed?  For changes like 
this, it is usually good to separate the "obvious" changes from the others 
into distinct patches.  Here are the ones that would be good to have 
comments added to them explaining them:

DataStructure/DSGraph.h: why is the method moved out of line?  Please add 
a comment before the out-of-line body indicating why it should not be 
moved back inline.

Analysis/AliasAnalysis.cpp: why don't you need the external stub?  Does it 
work for you like this?

namespace llvm {
   extern void BasicAAStub();
}

include/llvm/ADT/HashExtras.h: Is pointer support already built into the 
intel headers, making the hash implementation unneeded?  If so, please add 
a comment to the #ifndef indicating that.

As a general comment, please keep source lines within 80 columns. 
Otherwise the patches look great, thanks a lot!

-Chris

-- 
http://nondot.org/sabre/
http://llvm.cs.uiuc.edu/