[llvm] [VectorCombine] Pass flags during IR creation (PR #193271)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 13 23:35:46 PDT 2026
================
@@ -1445,19 +1445,36 @@ bool VectorCombine::scalarizeOpOrCmp(Instruction &I) {
cast<Constant>(VecC), Builder.getInt64(*Index));
Value *Scalar;
- if (CI)
- Scalar = Builder.CreateCmp(CI->getPredicate(), ScalarOps[0], ScalarOps[1]);
- else if (UO || BO)
- Scalar = Builder.CreateNAryOp(Opcode, ScalarOps);
- else
+ if (CI) {
+ FPMathOperator *FPMO = dyn_cast<FPMathOperator>(&I);
+ FMFSource FMF;
+ if (FPMO)
+ FMF = FPMO->getFastMathFlags();
+ Scalar =
+ Builder.CreateFlaggedCmp(CI->getPredicate(), ScalarOps[0], ScalarOps[1],
+ FMF, CI->getName() + ".scalar");
+ } else if (UO) {
+ // FNeg is the only unary operator.
+ Scalar = Builder.CreateFNegFMF(ScalarOps[0], UO, UO->getName() + ".scalar");
+ } else if (BO) {
+ OverflowingBinaryOperator *OBO = dyn_cast<OverflowingBinaryOperator>(&I);
+ bool HasNUW = OBO ? OBO->hasNoUnsignedWrap() : false;
+ bool HasNSW = OBO ? OBO->hasNoSignedWrap() : false;
+ PossiblyDisjointInst *PDI = dyn_cast<PossiblyDisjointInst>(&I);
+ bool IsDisjoint = PDI ? PDI->isDisjoint() : false;
+ PossiblyExactOperator *PEO = dyn_cast<PossiblyExactOperator>(&I);
+ bool IsExact = PEO ? PEO->isExact() : false;
+ FPMathOperator *FPMO = dyn_cast<FPMathOperator>(&I);
+ FMFSource FMF;
+ if (FPMO)
+ FMF = FPMO->getFastMathFlags();
+
+ Scalar = Builder.CreateFlaggedBinOp(
+ BO->getOpcode(), ScalarOps[0], ScalarOps[1], BO->getName() + ".scalar",
+ HasNUW, HasNSW, IsExact, IsDisjoint, FMF);
----------------
arsenm wrote:
I think the API here is wrong; You have to parse out all the flag holding variants anyway, so I would expect one Create* method per flag instruction kind
https://github.com/llvm/llvm-project/pull/193271
More information about the llvm-commits
mailing list