[llvm] [AssumptionCache] Remove incorrect assertion from `removeAffectedValues()` (PR #214524)
Nathan Corbyn via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 02:57:08 PDT 2026
cofibrant wrote:
> Dumb question: is it infeasible to add notifications to Use::set(),
I had a think about this and decided against basically because we'd require a new type of value handle and all of the associated plumbing and pay with a non-trivial compile time overhead in `Use::set()` only to implement a per-user observer pattern with no present in the rest of the codebase. This didn't seem like a good trade.
> or fix the pass (loop-rotate in this case)?
`loop-rotate` is not incorrect in what it's doing. The assumption cache is supposed to be self-updating and conservative. If anything is at fault, it's the assumption cache.
https://github.com/llvm/llvm-project/pull/214524
More information about the llvm-commits
mailing list