[llvm] [AMDGPU] Avoid quadratic erase in SIInstrWorklist (PR #211801)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 24 07:07:37 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Arseniy Obolenskiy (aobolensk)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/211801.diff
2 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIInstrInfo.cpp (+2-1)
- (modified) llvm/lib/Target/AMDGPU/SIInstrInfo.h (+10-8)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
index 28914d598a72d..633a815447d9a 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
@@ -7852,7 +7852,8 @@ SIInstrInfo::legalizeOperands(MachineInstr &MI,
}
void SIInstrWorklist::insert(MachineInstr *MI) {
- InstrList.insert(MI);
+ if (InSet.insert(MI).second)
+ InstrList.push_back(MI);
// Add MBUF instructiosn to deferred list.
int RsrcIdx =
AMDGPU::getNamedOperandIdx(MI->getOpcode(), AMDGPU::OpName::srsrc);
diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.h b/llvm/lib/Target/AMDGPU/SIInstrInfo.h
index 8e15b7b45b609..e57e80b88c2c6 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrInfo.h
+++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.h
@@ -18,6 +18,7 @@
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
#include "SIRegisterInfo.h"
#include "Utils/AMDGPUBaseInfo.h"
+#include "llvm/ADT/DenseSet.h"
#include "llvm/ADT/SetVector.h"
#include "llvm/CodeGen/TargetInstrInfo.h"
#include "llvm/CodeGen/TargetSchedule.h"
@@ -70,20 +71,19 @@ struct SIInstrWorklist {
void insert(MachineInstr *MI);
- MachineInstr *top() const {
- const auto *iter = InstrList.begin();
- return *iter;
- }
+ MachineInstr *top() const { return InstrList[Front]; }
void erase_top() {
- const auto *iter = InstrList.begin();
- InstrList.erase(iter);
+ InSet.erase(InstrList[Front]);
+ ++Front;
}
- bool empty() const { return InstrList.empty(); }
+ bool empty() const { return Front == InstrList.size(); }
void clear() {
InstrList.clear();
+ Front = 0;
+ InSet.clear();
DeferredList.clear();
}
@@ -93,7 +93,9 @@ struct SIInstrWorklist {
private:
/// InstrList contains the MachineInstrs.
- SetVector<MachineInstr *> InstrList;
+ SmallVector<MachineInstr *> InstrList;
+ DenseSet<MachineInstr *> InSet;
+ unsigned Front = 0;
/// Deferred instructions are specific MachineInstr
/// that will be added by insert method.
SetVector<MachineInstr *> DeferredList;
``````````
</details>
https://github.com/llvm/llvm-project/pull/211801
More information about the llvm-commits
mailing list