[llvm] aa590d1 - [SPIR-V] Fix SPIRVTools download step failing on rerun (#211561)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 23:56:56 PDT 2026


Author: Arseniy Obolenskiy
Date: 2026-07-24T08:56:51+02:00
New Revision: aa590d15f2c9f035ad70cd532bba859e7d127160

URL: https://github.com/llvm/llvm-project/commit/aa590d15f2c9f035ad70cd532bba859e7d127160
DIFF: https://github.com/llvm/llvm-project/commit/aa590d15f2c9f035ad70cd532bba859e7d127160.diff

LOG: [SPIR-V] Fix SPIRVTools download step failing on rerun (#211561)

Customized DOWNLOAD_COMMAND ran a raw `git clone`, which fails with
"destination path already exists" whenever ninja reruns the download
step against an already cloned checkout. Use the native
GIT_REPOSITORY/GIT_TAG (with default DOWNLOAD_COMMAND) step instead,
which handles this case correctly

Added: 
    

Modified: 
    llvm/tools/spirv-tools/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/tools/spirv-tools/CMakeLists.txt b/llvm/tools/spirv-tools/CMakeLists.txt
index 29d28ff2655c0..4505c82eee576 100644
--- a/llvm/tools/spirv-tools/CMakeLists.txt
+++ b/llvm/tools/spirv-tools/CMakeLists.txt
@@ -19,9 +19,7 @@ if (NOT SPIRV_DIS OR NOT SPIRV_VAL OR NOT SPIRV_AS OR NOT SPIRV_LINK)
     BINARY_DIR ${BINARY_DIR}
     BUILD_COMMAND ${CMAKE_COMMAND} --build ${BINARY_DIR} --target spirv-dis spirv-val spirv-as spirv-link
     BUILD_BYPRODUCTS ${BINARY_DIR}/tools/spirv-dis ${BINARY_DIR}/tools/spirv-val ${BINARY_DIR}/tools/spirv-as ${BINARY_DIR}/tools/spirv-link
-    DOWNLOAD_COMMAND git clone https://github.com/KhronosGroup/SPIRV-Tools.git SPIRVTools &&
-      cd SPIRVTools &&
-      ${Python3_EXECUTABLE} utils/git-sync-deps
+    PATCH_COMMAND ${Python3_EXECUTABLE} utils/git-sync-deps
     UPDATE_COMMAND git pull origin main &&
       ${Python3_EXECUTABLE} utils/git-sync-deps
     # Don't auto-update on every build.


        


More information about the llvm-commits mailing list