[polly] [ISL] Fix heap-use-after-free in cut_to_hyperplane (PR #211735)
Karthika Devi C via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 23 23:20:35 PDT 2026
https://github.com/kartcq created https://github.com/llvm/llvm-project/pull/211735
isl_tab_extend_cons() may realloc tab->con, invalidating the var pointer passed to cut_to_hyperplane() if it points into tab->con. Save var->is_row and var->index into local variables before the reallocation and use those copies afterwards.
Issue found when AddressSanitizer is enabled in the build.
>From 4d9366ff06fbc347f9e5e5c7b8491441fe969295 Mon Sep 17 00:00:00 2001
From: Karthika Devi C <kartc at qti.qualcomm.com>
Date: Thu, 23 Jul 2026 04:54:44 -0700
Subject: [PATCH] [ISL] Fix heap-use-after-free in cut_to_hyperplane
isl_tab_extend_cons() may realloc tab->con, invalidating the var
pointer passed to cut_to_hyperplane() if it points into tab->con.
Save var->is_row and var->index into local variables before the
reallocation and use those copies afterwards.
Issue found when AddressSanitizer is enabled in the build.
---
polly/lib/External/isl/isl_tab.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/polly/lib/External/isl/isl_tab.c b/polly/lib/External/isl/isl_tab.c
index d7bbcab80fe56..691f627827491 100644
--- a/polly/lib/External/isl/isl_tab.c
+++ b/polly/lib/External/isl/isl_tab.c
@@ -2703,6 +2703,8 @@ static isl_stat cut_to_hyperplane(struct isl_tab *tab, struct isl_tab_var *var)
isl_int *row;
int sgn;
unsigned off = 2 + tab->M;
+ int var_is_row;
+ int var_index;
if (var->is_zero)
return isl_stat_ok;
@@ -2711,6 +2713,12 @@ static isl_stat cut_to_hyperplane(struct isl_tab *tab, struct isl_tab_var *var)
"expecting non-redundant non-negative variable",
return isl_stat_error);
+ /* Save var fields before isl_tab_extend_cons, which may realloc
+ * tab->con and invalidate the var pointer.
+ */
+ var_is_row = var->is_row;
+ var_index = var->index;
+
if (isl_tab_extend_cons(tab, 1) < 0)
return isl_stat_error;
@@ -2725,14 +2733,14 @@ static isl_stat cut_to_hyperplane(struct isl_tab *tab, struct isl_tab_var *var)
tab->row_var[tab->n_row] = ~r;
row = tab->mat->row[tab->n_row];
- if (var->is_row) {
- isl_int_set(row[0], tab->mat->row[var->index][0]);
+ if (var_is_row) {
+ isl_int_set(row[0], tab->mat->row[var_index][0]);
isl_seq_neg(row + 1,
- tab->mat->row[var->index] + 1, 1 + tab->n_col);
+ tab->mat->row[var_index] + 1, 1 + tab->n_col);
} else {
isl_int_set_si(row[0], 1);
isl_seq_clr(row + 1, 1 + tab->n_col);
- isl_int_set_si(row[off + var->index], -1);
+ isl_int_set_si(row[off + var_index], -1);
}
tab->n_row++;
More information about the llvm-commits
mailing list