[llvm] [LLVM][InstCombine] Enable simplification of SVE predicate binops. (PR #211016)

Matthew Devereau via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 02:10:27 PDT 2026


================
@@ -2016,32 +2045,24 @@ tryCombineFromSVBoolBinOp(InstCombiner &IC, IntrinsicInst &II) {
     return std::nullopt;
   }
 
-  auto BinOpPred = BinOp->getOperand(0);
-  auto BinOpOp1 = BinOp->getOperand(1);
-  auto BinOpOp2 = BinOp->getOperand(2);
-
-  auto PredIntr = dyn_cast<IntrinsicInst>(BinOpPred);
-  if (!PredIntr ||
-      PredIntr->getIntrinsicID() != Intrinsic::aarch64_sve_convert_to_svbool)
-    return std::nullopt;
+  Value *BinOpPred = BinOp->getOperand(0);
+  Value *BinOpOp1 = BinOp->getOperand(1);
+  Value *BinOpOp2 = BinOp->getOperand(2);
 
-  auto PredOp = PredIntr->getOperand(0);
-  auto PredOpTy = cast<VectorType>(PredOp->getType());
-  if (PredOpTy != II.getType())
+  Value *PredOp;
+  if (!match(BinOpPred, m_ConvertToSVBool(m_SpecificType(Ty, PredOp))))
     return std::nullopt;
 
   SmallVector<Value *> NarrowedBinOpArgs = {PredOp};
-  auto NarrowBinOpOp1 = IC.Builder.CreateIntrinsic(
-      Intrinsic::aarch64_sve_convert_from_svbool, {PredOpTy}, {BinOpOp1});
+  Value *NarrowBinOpOp1 = CreateConvertFromSVBool(Ty, BinOpOp1);
   NarrowedBinOpArgs.push_back(NarrowBinOpOp1);
   if (BinOpOp1 == BinOpOp2)
     NarrowedBinOpArgs.push_back(NarrowBinOpOp1);
   else
-    NarrowedBinOpArgs.push_back(IC.Builder.CreateIntrinsic(
-        Intrinsic::aarch64_sve_convert_from_svbool, {PredOpTy}, {BinOpOp2}));
+    NarrowedBinOpArgs.push_back(CreateConvertFromSVBool(Ty, BinOpOp2));
 
-  auto NarrowedBinOp =
-      IC.Builder.CreateIntrinsic(IntrinsicID, {PredOpTy}, NarrowedBinOpArgs);
+  Value *NarrowedBinOp =
+      IC.Builder.CreateIntrinsic(IntrinsicID, Ty, NarrowedBinOpArgs);
----------------
MDevereau wrote:

It looks easy to reduce existing code and get rid of the SmallVector:
```
  Value *NarrowBinOpOp1 = IC.Builder.CreateIntrinsic(FromSVBool, Ty, BinOpOp1);
  Value *NarrowBinOpOp2 = NarrowBinOpOp1;
  if (BinOpOp1 != BinOpOp2)
    NarrowBinOpOp2 = IC.Builder.CreateIntrinsic(FromSVBool, Ty, BinOpOp2);
    
  Value *NarrowedBinOp =
      IC.Builder.CreateIntrinsic(IntrinsicID, Ty, {PredOp, NarrowBinOpOp1, NarrowBinOpOp2});
```

https://github.com/llvm/llvm-project/pull/211016


More information about the llvm-commits mailing list