[llvm] 4aa8d56 - [LLVM][SVE] Convert FFR intrinsic definition to use IntrRead/IntrWrite. (#210084)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 21 05:49:21 PDT 2026
Author: Paul Walker
Date: 2026-07-21T13:49:16+01:00
New Revision: 4aa8d561bb06ecf89c723524fddbf0b58c5ec205
URL: https://github.com/llvm/llvm-project/commit/4aa8d561bb06ecf89c723524fddbf0b58c5ec205
DIFF: https://github.com/llvm/llvm-project/commit/4aa8d561bb06ecf89c723524fddbf0b58c5ec205.diff
LOG: [LLVM][SVE] Convert FFR intrinsic definition to use IntrRead/IntrWrite. (#210084)
Follows on from https://github.com/llvm/llvm-project/issues/154144 to
better articulate the FFR intrinsics memory effects.
I've been deliberatly cautious with marking FFR as read/write for the
load intrinsics. There is an argument they could be write only but I'm
not looking to optimise FFR accesses at this stage.
Added:
Modified:
llvm/include/llvm/IR/IntrinsicsAArch64.td
Removed:
################################################################################
diff --git a/llvm/include/llvm/IR/IntrinsicsAArch64.td b/llvm/include/llvm/IR/IntrinsicsAArch64.td
index 6078e1438ceee..8abc66ff1e90e 100644
--- a/llvm/include/llvm/IR/IntrinsicsAArch64.td
+++ b/llvm/include/llvm/IR/IntrinsicsAArch64.td
@@ -733,6 +733,7 @@ def int_aarch64_neon_tbx3 : AdvSIMD_Tbx3_Intrinsic;
def int_aarch64_neon_tbx4 : AdvSIMD_Tbx4_Intrinsic;
// Maps Memory locations to registers.
+defvar FFR = InaccessibleMem;
defvar FPMR = InaccessibleMem;
defvar ZT0 = TargetMem0;
defvar ZA = TargetMem1;
@@ -1083,7 +1084,7 @@ let TargetPrefix = "aarch64" in { // All intrinsics start with "llvm.aarch64.".
class AdvSIMD_1Vec_PredLoad_WriteFFR_Intrinsic
: DefaultAttrsIntrinsic<[llvm_anyvector_ty],
[LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>, llvm_anyptr_ty],
- [IntrInaccessibleMemOrArgMemOnly]>;
+ [IntrRead<[ArgMem, FFR]>, IntrWrite<[FFR]>]>;
class AdvSIMD_1Vec_PredStore_Intrinsic
: DefaultAttrsIntrinsic<[],
@@ -1590,7 +1591,7 @@ class AdvSIMD_GatherLoad_SV_64b_Offsets_WriteFFR_Intrinsic
llvm_anyptr_ty,
LLVMScalarOrSameVectorWidth<0, llvm_i64_ty>
],
- [IntrInaccessibleMemOrArgMemOnly]>;
+ [IntrRead<[ArgMem, FFR]>, IntrWrite<[FFR]>]>;
class AdvSIMD_GatherLoad_SV_32b_Offsets_Intrinsic
: DefaultAttrsIntrinsic<[llvm_anyvector_ty],
@@ -1608,7 +1609,7 @@ class AdvSIMD_GatherLoad_SV_32b_Offsets_WriteFFR_Intrinsic
llvm_anyptr_ty,
LLVMScalarOrSameVectorWidth<0, llvm_i32_ty>
],
- [IntrInaccessibleMemOrArgMemOnly]>;
+ [IntrRead<[ArgMem, FFR]>, IntrWrite<[FFR]>]>;
class AdvSIMD_GatherLoad_VS_Intrinsic
: DefaultAttrsIntrinsic<[llvm_anyvector_ty],
@@ -1644,7 +1645,7 @@ class AdvSIMD_GatherLoad_VS_WriteFFR_Intrinsic
llvm_anyvector_ty,
llvm_i64_ty
],
- [IntrInaccessibleMemOrArgMemOnly]>;
+ [IntrRead<[ArgMem, FFR]>, IntrWrite<[FFR]>]>;
class AdvSIMD_ScatterStore_SV_64b_Offsets_Intrinsic
: DefaultAttrsIntrinsic<[],
@@ -1955,10 +1956,10 @@ def int_aarch64_sve_lastp : AdvSIMD_SVE_CNTP_Intrinsic<[IntrSpeculatable]>;
// FFR manipulation
//
-def int_aarch64_sve_rdffr : ClangBuiltin<"__builtin_sve_svrdffr">, DefaultAttrsIntrinsic<[llvm_nxv16i1_ty], [], [IntrReadMem, IntrInaccessibleMemOnly]>;
-def int_aarch64_sve_rdffr_z : ClangBuiltin<"__builtin_sve_svrdffr_z">, DefaultAttrsIntrinsic<[llvm_nxv16i1_ty], [llvm_nxv16i1_ty], [IntrReadMem, IntrInaccessibleMemOnly]>;
-def int_aarch64_sve_setffr : ClangBuiltin<"__builtin_sve_svsetffr">, DefaultAttrsIntrinsic<[], [], [IntrWriteMem, IntrInaccessibleMemOnly]>;
-def int_aarch64_sve_wrffr : ClangBuiltin<"__builtin_sve_svwrffr">, DefaultAttrsIntrinsic<[], [llvm_nxv16i1_ty], [IntrWriteMem, IntrInaccessibleMemOnly]>;
+def int_aarch64_sve_rdffr : ClangBuiltin<"__builtin_sve_svrdffr">, DefaultAttrsIntrinsic<[llvm_nxv16i1_ty], [], [IntrRead<[FFR]>, IntrReadOnly]>;
+def int_aarch64_sve_rdffr_z : ClangBuiltin<"__builtin_sve_svrdffr_z">, DefaultAttrsIntrinsic<[llvm_nxv16i1_ty], [llvm_nxv16i1_ty], [IntrRead<[FFR]>, IntrReadOnly]>;
+def int_aarch64_sve_setffr : ClangBuiltin<"__builtin_sve_svsetffr">, DefaultAttrsIntrinsic<[], [], [IntrWrite<[FFR]>, IntrWriteOnly]>;
+def int_aarch64_sve_wrffr : ClangBuiltin<"__builtin_sve_svwrffr">, DefaultAttrsIntrinsic<[], [llvm_nxv16i1_ty], [IntrWrite<[FFR]>, IntrWriteOnly]>;
//
// Saturating scalar arithmetic
More information about the llvm-commits
mailing list