[llvm] [X86] Fix miscompile of fptosi.sat.iN.f16 for NaN under avx512fp16 (PR #210556)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 20 00:20:07 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/X86/X86ISelLowering.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 767452ff4..1bfec9f31 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -22686,9 +22686,8 @@ X86TargetLowering::LowerFP_TO_INT_SAT(SDValue Op, SelectionDAG &DAG) const {
// simply doesn't match, leaving the already-correct truncated zero in
// place.
ISD::CondCode MinCC = (IsSigned && DstVT != TmpVT) ? ISD::CondCode::SETOLT
- : ISD::CondCode::SETULT;
- Select = DAG.getSelectCC(
- dl, Src, MinFloatNode, MinIntNode, Select, MinCC);
+ : ISD::CondCode::SETULT;
+ Select = DAG.getSelectCC(dl, Src, MinFloatNode, MinIntNode, Select, MinCC);
}
// If Src OGT MaxFloat, select MaxInt.
``````````
</details>
https://github.com/llvm/llvm-project/pull/210556
More information about the llvm-commits
mailing list