[llvm] [DWARFLinker] Make synthetic type names deterministic under threading (PR #209553)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `llvm` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/35880

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: lang/c/vla/TestVLA.py (857 of 2682)
PASS: lldb-api :: lang/cpp/bool/TestCPPBool.py (858 of 2682)
PASS: lldb-api :: lang/cpp/break-on-initializers/TestBreakOnCPP11Initializers.py (859 of 2682)
UNSUPPORTED: lldb-api :: lang/cpp/breakpoint_in_member_func_w_non_primitive_params/TestBreakpointInMemberFuncWNonPrimitiveParams.py (860 of 2682)
PASS: lldb-api :: lang/c/step-target/TestStepTarget.py (861 of 2682)
PASS: lldb-api :: lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py (862 of 2682)
PASS: lldb-api :: lang/cpp/builtin_types/char/TestCharTypes.py (863 of 2682)
PASS: lldb-api :: lang/cpp/builtin_types/int/TestIntTypes.py (864 of 2682)
PASS: lldb-api :: lang/cpp/builtin_types/long_int/TestLongIntTypes.py (865 of 2682)
PASS: lldb-api :: lang/cpp/call-function/TestCallCPPFunction.py (866 of 2682)
FAIL: lldb-api :: functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py (867 of 2682)
******************** TEST 'lldb-api :: functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --triple aarch64-unknown-linux-gnu --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --lldb-python-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/local/lib/python3.10/dist-packages --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --cmake-build-type Release /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency -p TestFrameProviderCircularDependency.py
--
Exit Code: 1

Command Output (stdout):
--
Skipping the following test categories: libc++, msvcstl, dsym, pdb, gmodules, debugserver, objc

--
Command Output (stderr):
--
FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_circular_dependency_evaluate_expression_in_get_frame (TestFrameProviderCircularDependency.FrameProviderCircularDependencyTestCase)
Log Files:
 - /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency/Failure_test_circular_dependency_evaluate_expression_in_get_frame.log
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_circular_dependency_handle_command_in_init (TestFrameProviderCircularDependency.FrameProviderCircularDependencyTestCase)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_circular_dependency_with_function_replacement (TestFrameProviderCircularDependency.FrameProviderCircularDependencyTestCase)
======================================================================
FAIL: test_circular_dependency_evaluate_expression_in_get_frame (TestFrameProviderCircularDependency.FrameProviderCircularDependencyTestCase)
   Test that calling EvaluateExpression in get_frame_at_index doesn't
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py", line 204, in test_circular_dependency_evaluate_expression_in_get_frame
    self.assertIsNotNone(
AssertionError: unexpectedly None : Frame 1 should have function name
Config=aarch64-/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang
----------------------------------------------------------------------
Ran 3 tests in 36.026s

FAILED (failures=1)

--

********************
PASS: lldb-api :: lang/cpp/class-loading-via-member-typedef/TestClassLoadingViaMemberTypedef.py (868 of 2682)
PASS: lldb-api :: lang/cpp/chained-calls/TestCppChainedCalls.py (869 of 2682)

```

</details>

https://github.com/llvm/llvm-project/pull/209553