[llvm] [SPIRV] Fix crash when lowering functions with aggregate return types (PR #209027)

Dmitry Sidorov via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 06:21:30 PDT 2026


================
@@ -3,905 +3,3 @@
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-//
-// This pass modifies function signatures containing aggregate arguments
-// and/or return value before IRTranslator. Information about the original
-// signatures is stored in metadata. It is used during call lowering to
-// restore correct SPIR-V types of function arguments and return values.
-// This pass also substitutes some llvm intrinsic calls with calls to newly
-// generated functions (as the Khronos LLVM/SPIR-V Translator does).
-//
-// NOTE: this pass is a module-level one due to the necessity to modify
-// GVs/functions.
-//
-//===----------------------------------------------------------------------===//
----------------
MrSidims wrote:

Frankly, while deep in my heart I have a feeling, that the way to solve all our problems with mutated types is to "delete and re-write everything", I believe that this PR is way too committed to this ambitious refactoring.

@SparshGarg999  would you mind expressing, why you decided to remove the entire pass?

https://github.com/llvm/llvm-project/pull/209027


More information about the llvm-commits mailing list