[llvm] [IR] Implementation and lowering of bitinsert and bitextract (PR #200605)

Alexis Engelke via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 03:42:55 PDT 2026


================
@@ -363,8 +363,8 @@ TEST_F(IR2VecTestFixture, GetInstVec_Symbolic) {
   EXPECT_EQ(AddEmb.size(), 2u);
   EXPECT_EQ(RetEmb.size(), 2u);
 
-  EXPECT_TRUE(AddEmb.approximatelyEquals(Embedding(2, 26.1)));
-  EXPECT_TRUE(RetEmb.approximatelyEquals(Embedding(2, 15.8)));
+  EXPECT_TRUE(AddEmb.approximatelyEquals(Embedding(2, 26.7)));
----------------
aengelke wrote:

Side note: these ir2vec tests are written in a super-annoying way. They should not hard-code some magic and hard-to-understand values. IMO these tests should be dropped instead...

https://github.com/llvm/llvm-project/pull/200605


More information about the llvm-commits mailing list