[llvm] [offload] fix failure of olCreateProgramTest.TruncatedBinary (PR #210024)

[via llvm-commits]

Jan =?utf-8?q?Trusiłło?= <jan.trusillo at intel.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/210024 at github.com>


https://github.com/311Volt updated https://github.com/llvm/llvm-project/pull/210024

>From c106d5563240fb084fbf329e98cbe0a27d4ee715 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Trusi=C5=82=C5=82o?= <jan.trusillo at intel.com>
Date: Thu, 16 Jul 2026 10:16:14 +0000
Subject: [PATCH 1/2] [offload] fix failure of
 olCreateProgramTest.TruncatedBinary

---
 offload/unittests/OffloadAPI/program/olCreateProgram.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
index 4f661cf4b4cd0..f3fe9d0bfbee9 100644
--- a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
+++ b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
@@ -86,6 +86,8 @@ TEST_P(olCreateProgramTest, InvalidBinary) {
 }
 
 TEST_P(olCreateProgramTest, TruncatedBinary) {
+  SKIP_KNOWN_FAILURE(AMDGPU{"HSA reads past end of buffer, causing a crash"});
+
   std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
   ASSERT_GT(DeviceBin->getBufferSize(), 1lu);

>From 003ad525e18d137ae360c128dbd2cf8e53165add Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Trusi=C5=82=C5=82o?= <jan.trusillo at intel.com>
Date: Thu, 16 Jul 2026 10:29:21 +0000
Subject: [PATCH 2/2] remove TruncatedBinary test

---
 .../OffloadAPI/program/olCreateProgram.cpp         | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
index f3fe9d0bfbee9..8d04b058d3c25 100644
--- a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
+++ b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
@@ -85,20 +85,6 @@ TEST_P(olCreateProgramTest, InvalidBinary) {
   ASSERT_EQ(Program, nullptr);
 }
 
-TEST_P(olCreateProgramTest, TruncatedBinary) {
-  SKIP_KNOWN_FAILURE(AMDGPU{"HSA reads past end of buffer, causing a crash"});
-
-  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
-  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
-  ASSERT_GT(DeviceBin->getBufferSize(), 1lu);
-
-  ol_program_handle_t Program = nullptr;
-  ASSERT_ERROR(OL_ERRC_INVALID_BINARY,
-               olCreateProgram(Device, DeviceBin->getBufferStart(),
-                               DeviceBin->getBufferSize() / 2, &Program));
-  ASSERT_EQ(Program, nullptr);
-}
-
 TEST_P(olCreateProgramTest, WrongArchitecture) {
   // Pick a backend different from the device's own, so the loaded binary is
   // valid but built for the wrong architecture.