[llvm] [MergeFunctions] Preserve instruction-level profile metadata during merging (PR #208009)

[Alok Kumar Sharma via llvm-commits]

alokkrsharma wrote:

> @alokkrsharma just a heads up in case it got lost with another failure in the upstream bots, this change seems to be causing a crash in two unit tests, MergeFunctionsTest.TrueOutputFunctionsTest and MergeFunctionsTest.TrueOutputModuleTest. The stack trace looks like the following:
> 
> ```
> [ RUN      ] MergeFunctionsTest.TrueOutputFunctionsTest
>  #0 0x0000589565773d39 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x587d39)
>  #1 0x0000589565770fac llvm::sys::RunSignalHandlers() (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x584fac)
>  #2 0x0000589565771112 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
>  #3 0x000078d451c56520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
>  #4 0x000058956528f42b llvm::detail::AnalysisResultModel<llvm::Module, llvm::InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>, llvm::InnerAnalysisManagerProxy<llvm::AnalysisManager<llvm::Function>, llvm::Module>::Result, llvm::AnalysisManager<llvm::Module>::Invalidator, true>::~AnalysisResultModel() crtstuff.c:0:0
>  #5 0x000058956528e6b5 (anonymous namespace)::MergeFunctionsTest::~MergeFunctionsTest() MergeFunctionsTest.cpp:0:0
>  #6 0x000058956528eb27 (anonymous namespace)::MergeFunctionsTest_TrueOutputFunctionsTest_Test::~MergeFunctionsTest_TrueOutputFunctionsTest_Test() MergeFunctionsTest.cpp:0:0
>  #7 0x00005895657c982c testing::TestInfo::Run() (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x5dd82c)
>  #8 0x00005895657c9f11 testing::TestSuite::Run() (.part.0) gtest-all.cc:0:0
>  #9 0x00005895657d493a testing::internal::UnitTestImpl::RunAllTests() (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x5e893a)
> #10 0x00005895657be76f testing::UnitTest::Run() (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x5d276f)
> #11 0x0000589565255908 main (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x69908)
> #12 0x000078d451c3dd90 __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
> #13 0x000078d451c3de40 call_init ./csu/../csu/libc-start.c:128:20
> #14 0x000078d451c3de40 __libc_start_main ./csu/../csu/libc-start.c:379:5
> #15 0x000058956525d485 _start (/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/unittests/Transforms/IPO/./IPOTests+0x71485)
> ```
> 
> You can see the crash on the buildbot at https://lab.llvm.org/buildbot/#/builders/144/builds/59351.
> 
> Can you take a look?

Thanks for letting me know. I'll fix it.

https://github.com/llvm/llvm-project/pull/208009