[llvm] [SROA] Fix assertion failure when promoting self-referential load/store (PR #208826)

[Krisitan Erik Olsen via llvm-commits]

Kristianerik wrote:

Cleaned up the test, removed fastcc and simplified the block names. Verified both directions still work.

https://github.com/llvm/llvm-project/pull/208826