[llvm] 922b1a9 - Revert "[cmake] Fix VSINSTALLDIR check in FindDIASDK module (#208524)" (#209137)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 02:19:57 PDT 2026


Author: Charles Zablit
Date: 2026-07-14T10:19:52+01:00
New Revision: 922b1a9da0a16e9df23c1a91203cf37c24d5c26d

URL: https://github.com/llvm/llvm-project/commit/922b1a9da0a16e9df23c1a91203cf37c24d5c26d
DIFF: https://github.com/llvm/llvm-project/commit/922b1a9da0a16e9df23c1a91203cf37c24d5c26d.diff

LOG: Revert "[cmake] Fix VSINSTALLDIR check in FindDIASDK module (#208524)" (#209137)

This reverts commit 4c5e15667fe384e434961fe44cf5950dc309fdf1.

https://github.com/llvm/llvm-project/pull/208524 fixed a flag which
enabled testing with the DIA SDK. This broke all Windows build bots,
because the SDK is not available in the PATH.

Added: 
    

Modified: 
    llvm/cmake/modules/FindDIASDK.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/FindDIASDK.cmake b/llvm/cmake/modules/FindDIASDK.cmake
index 6b38260beba89..f3133d29de3b2 100644
--- a/llvm/cmake/modules/FindDIASDK.cmake
+++ b/llvm/cmake/modules/FindDIASDK.cmake
@@ -21,7 +21,7 @@ endif()
 if(LLVM_WINSYSROOT)
   set(MSVC_DIA_SDK_DIR "${LLVM_WINSYSROOT}/DIA SDK" CACHE PATH
       "Path to the DIA SDK")
-elseif(DEFINED ENV{VSINSTALLDIR})
+elseif($ENV{VSINSTALLDIR})
   set(MSVC_DIA_SDK_DIR "$ENV{VSINSTALLDIR}DIA SDK" CACHE PATH
       "Path to the DIA SDK")
 elseif(NOT DEFINED MSVC_DIA_SDK_DIR)


        


More information about the llvm-commits mailing list