[llvm] [VPlan] Type VP(Recipe|Block)Ty SubclassID (NFC) (PR #209132)

Ramkumar Ramachandra via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 01:05:03 PDT 2026


artagnon wrote:

> > > Nit, is it possible to avoid force pushing in your workflow? It causes the previous review comments to disappear in the files changed panel on GitHub
> > 
> > 
> > Unfortunately not. I thought that GitHub was better about preserving comments with rebases after the latest update? (At least that's what they advertised?)
> 
> Does `git pull upstream main` not work for pulling in changes from main?

Assuming that pull.rebase is set to false, that would be a merge-based workflow, which comes with its own set of issues. I had a discussion with Nikita and Florian about this already: Nikita and I prefer the rebase-based workflow, while many others including Florian prefer the merge-based workflow.

https://github.com/llvm/llvm-project/pull/209132


More information about the llvm-commits mailing list