[llvm] [offload] add unit tests for olCreateProgram (PR #206462)

[via llvm-commits]

Jan =?utf-8?q?Trusiłło?= <jan.trusillo at intel.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/206462 at github.com>


https://github.com/311Volt updated https://github.com/llvm/llvm-project/pull/206462

>From d04a21ccd3ed4e784a6b6d2f34e7d30c0dbbccff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Trusi=C5=82=C5=82o?= <113amper at gmail.com>
Date: Wed, 17 Jun 2026 13:22:06 +0000
Subject: [PATCH 1/2] [offload] add unit tests for olCreateProgram

Add tests for olCreateProgram param validation & fail on invalid program
---
 .../OffloadAPI/program/olCreateProgram.cpp    | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
index 5363957e78453..513d32167a285 100644
--- a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
+++ b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
@@ -26,3 +26,60 @@ TEST_P(olCreateProgramTest, Success) {
 
   ASSERT_SUCCESS(olDestroyProgram(Program));
 }
+
+TEST_P(olCreateProgramTest, NullDeviceHandle) {
+
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
+
+  ol_program_handle_t Program;
+  ASSERT_ERROR(OL_ERRC_INVALID_NULL_HANDLE,
+               olCreateProgram(nullptr, DeviceBin->getBufferStart(),
+                               DeviceBin->getBufferSize(), &Program));
+}
+
+TEST_P(olCreateProgramTest, NullProgData) {
+
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
+
+  ol_program_handle_t Program;
+  ASSERT_ERROR(
+      OL_ERRC_INVALID_NULL_POINTER,
+      olCreateProgram(Device, nullptr, DeviceBin->getBufferSize(), &Program));
+}
+
+TEST_P(olCreateProgramTest, NullOutputProgram) {
+
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
+
+  ASSERT_ERROR(OL_ERRC_INVALID_NULL_POINTER,
+               olCreateProgram(Device, DeviceBin->getBufferStart(),
+                               DeviceBin->getBufferSize(), nullptr));
+}
+
+TEST_P(olCreateProgramTest, ZeroSizeBinary) {
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GT(DeviceBin->getBufferSize(), 0lu);
+
+  ol_program_handle_t Program = nullptr;
+
+  // backend rejection of a binary is not guaranteed to map to a specific ol_errc_t, so we ASSERT_ANY_ERROR for now
+  ASSERT_ANY_ERROR(
+      olCreateProgram(Device, DeviceBin->getBufferStart(), 0, &Program));
+  ASSERT_EQ(Program, nullptr);
+}
+
+TEST_P(olCreateProgramTest, InvalidBinary) {
+  const char InvalidBinary[] = "not an offload binary";
+
+  ol_program_handle_t Program = nullptr;
+  ASSERT_ANY_ERROR(olCreateProgram(Device, InvalidBinary,
+                                   sizeof(InvalidBinary) - 1, &Program));
+  ASSERT_EQ(Program, nullptr);
+}

>From 41917eccd58303ae1f9031c0a0e453ee0d7a6703 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Trusi=C5=82=C5=82o?= <jan.trusillo at intel.com>
Date: Wed, 1 Jul 2026 09:46:52 +0200
Subject: [PATCH 2/2] whitespace correction

---
 offload/unittests/OffloadAPI/program/olCreateProgram.cpp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
index 513d32167a285..7bbd2308e1d18 100644
--- a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
+++ b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
@@ -14,7 +14,6 @@ using olCreateProgramTest = OffloadDeviceTest;
 OFFLOAD_TESTS_INSTANTIATE_DEVICE_FIXTURE(olCreateProgramTest);
 
 TEST_P(olCreateProgramTest, Success) {
-
   std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
   ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
@@ -28,7 +27,6 @@ TEST_P(olCreateProgramTest, Success) {
 }
 
 TEST_P(olCreateProgramTest, NullDeviceHandle) {
-
   std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
   ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
@@ -40,7 +38,6 @@ TEST_P(olCreateProgramTest, NullDeviceHandle) {
 }
 
 TEST_P(olCreateProgramTest, NullProgData) {
-
   std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
   ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
@@ -52,7 +49,6 @@ TEST_P(olCreateProgramTest, NullProgData) {
 }
 
 TEST_P(olCreateProgramTest, NullOutputProgram) {
-
   std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
   ASSERT_GE(DeviceBin->getBufferSize(), 0lu);