[llvm] [offload] add unit tests for olCreateProgram (PR #206462)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-offload

Author: 311Volt

<details>
<summary>Changes</summary>

Add tests for olCreateProgram param validation & fail on invalid program

---
Full diff: https://github.com/llvm/llvm-project/pull/206462.diff


1 Files Affected:

- (modified) offload/unittests/OffloadAPI/program/olCreateProgram.cpp (+57) 


``````````diff
diff --git a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
index 5363957e78453..513d32167a285 100644
--- a/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
+++ b/offload/unittests/OffloadAPI/program/olCreateProgram.cpp
@@ -26,3 +26,60 @@ TEST_P(olCreateProgramTest, Success) {
 
   ASSERT_SUCCESS(olDestroyProgram(Program));
 }
+
+TEST_P(olCreateProgramTest, NullDeviceHandle) {
+
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
+
+  ol_program_handle_t Program;
+  ASSERT_ERROR(OL_ERRC_INVALID_NULL_HANDLE,
+               olCreateProgram(nullptr, DeviceBin->getBufferStart(),
+                               DeviceBin->getBufferSize(), &Program));
+}
+
+TEST_P(olCreateProgramTest, NullProgData) {
+
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
+
+  ol_program_handle_t Program;
+  ASSERT_ERROR(
+      OL_ERRC_INVALID_NULL_POINTER,
+      olCreateProgram(Device, nullptr, DeviceBin->getBufferSize(), &Program));
+}
+
+TEST_P(olCreateProgramTest, NullOutputProgram) {
+
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GE(DeviceBin->getBufferSize(), 0lu);
+
+  ASSERT_ERROR(OL_ERRC_INVALID_NULL_POINTER,
+               olCreateProgram(Device, DeviceBin->getBufferStart(),
+                               DeviceBin->getBufferSize(), nullptr));
+}
+
+TEST_P(olCreateProgramTest, ZeroSizeBinary) {
+  std::unique_ptr<llvm::MemoryBuffer> DeviceBin;
+  ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Device, DeviceBin));
+  ASSERT_GT(DeviceBin->getBufferSize(), 0lu);
+
+  ol_program_handle_t Program = nullptr;
+
+  // backend rejection of a binary is not guaranteed to map to a specific ol_errc_t, so we ASSERT_ANY_ERROR for now
+  ASSERT_ANY_ERROR(
+      olCreateProgram(Device, DeviceBin->getBufferStart(), 0, &Program));
+  ASSERT_EQ(Program, nullptr);
+}
+
+TEST_P(olCreateProgramTest, InvalidBinary) {
+  const char InvalidBinary[] = "not an offload binary";
+
+  ol_program_handle_t Program = nullptr;
+  ASSERT_ANY_ERROR(olCreateProgram(Device, InvalidBinary,
+                                   sizeof(InvalidBinary) - 1, &Program));
+  ASSERT_EQ(Program, nullptr);
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/206462