[llvm] [AMDGPU] Add folding ISD::SELECT from vXiY into vZi32 with X * Y = Z * 32 (PR #173328)

[Matt Arsenault via llvm-commits]

================
@@ -7033,6 +7033,67 @@ static SDValue combineSelectAsExtAnd(SDValue Cond, SDValue T, SDValue F,
   return DAG.getNode(ISD::AND, DL, OpVT, CondMask, T.getOperand(0));
 }
 
+/// Try to convert
+/// `(vXiY SELECT \p Cond, (vXiY \p TrueVal), (vXiY \p FalseVal))` into
+/// `(vPiQ SELECT Cond, (vPiQ NewTrue), (vPiQ NewFalse))` with:
+/// 1. vXiY is not legal type
+/// 2. vPiQ is legal type
+/// 3. X * Y = P * Q
+/// This prevents promotion of integer vectors like v32i4 to v32i16
+/// which can create more type casting operations.
+static SDValue castIntVectorSelect(SDNode *N, SelectionDAG &DAG,
+                                   const TargetLowering &TLI, SDValue Cond,
+                                   SDValue TrueVal, SDValue FalseVal) {
+  EVT ResultVT = N->getValueType(0);
+  if (ResultVT.isScalableVector() || TLI.isTypeLegal(ResultVT))
+    return SDValue();
+
+  EVT EltVT = ResultVT.getVectorElementType();
+  if (!EltVT.isInteger())
+    return SDValue();
+
+  // Widen vector to power of 2
+  if (!ResultVT.isSimple() && !ResultVT.isPow2VectorType() &&
+      TLI.getTypeAction(*DAG.getContext(), ResultVT) ==
+          TargetLowering::TypeWidenVector) {
+    SDValue WidenTrue = DAG.WidenVector(TrueVal, SDLoc(TrueVal));
+    SDValue WidenFalse = DAG.WidenVector(FalseVal, SDLoc(FalseVal));
+
+    EVT WidenVT = WidenTrue.getValueType();
+    SDValue WidenSelect = DAG.getNode(ISD::SELECT, SDLoc(N), WidenVT, Cond,
+                                      WidenTrue, WidenFalse);
+    return DAG.getExtractSubvector(SDLoc(N), ResultVT, WidenSelect, 0);
+  }
+
+  TypeSize NewEltBitSize = EltVT.getSizeInBits() * 2;
+  EVT NewVT = ResultVT.getIntegerVectorWithElementWidth(*DAG.getContext(),
+                                                        NewEltBitSize);
+
+  while (NewVT != EVT() && !TLI.isTypeLegal(NewVT)) {
----------------
arsenm wrote:

It still does not feel right to have a loop trying to find the type combined with getLegalTypeToTransformTo, which is already internally looping to find a type

https://github.com/llvm/llvm-project/pull/173328