[llvm] [DropUnnecessaryAssumes] Fix iterator invalidation. (PR #203765)

[Nikolas Klauser via llvm-commits]

https://github.com/philnik777 commented:

Would it be possible to instead introduce a `replaceAssumption` function in the assumption cache? Replacing (bundle) assumptions is a relatively common occurrence I think - at least when simplifying/dropping assumes. That should also reduce the amount of dead assumes registered, since we can simply replace the `WeakVH` instead of keeping it around unnecessarily.


https://github.com/llvm/llvm-project/pull/203765