[llvm] [AMDGPU] Fix GISel lowering for amdgcn_s_quadmask, amdgcn_s_wqm (PR #202704)
Chinmay Deshpande via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 9 12:59:32 PDT 2026
https://github.com/chinmaydd updated https://github.com/llvm/llvm-project/pull/202704
>From 03361ec46e43e46bc8ad3d6dc93b2c66c545efa9 Mon Sep 17 00:00:00 2001
From: Chinmay Deshpande <chdeshpa at amd.com>
Date: Tue, 9 Jun 2026 11:53:47 -0400
Subject: [PATCH 1/2] [AMDGPU] Mark amdgcn_s_quadmask, amdgcn_s_wqm as
AlwaysUniform
---
llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp | 8 +++-----
llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td | 2 ++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp b/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp
index 3b14e9661d7db..1a54b3f813c6b 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp
@@ -1744,11 +1744,9 @@ RegBankLegalizeRules::RegBankLegalizeRules(const GCNSubtarget &_ST,
addRulesForIOpcs({amdgcn_readlane}, StandardB)
.Uni(B32, {{SgprB32}, {IntrId, VgprB32, SgprB32_ReadFirstLane}});
- addRulesForIOpcs({amdgcn_s_quadmask, amdgcn_s_wqm}, StandardB)
- .Uni(B32, {{SgprB32}, {IntrId, SgprB32}})
- .Div(B32, {{Sgpr32ToVgprDst}, {IntrId, SgprB32_ReadFirstLane}})
- .Uni(B64, {{SgprB64}, {IntrId, SgprB64}})
- .Div(B64, {{Sgpr64ToVgprDst}, {IntrId, SgprB64_ReadFirstLane}});
+ addRulesForIOpcs({amdgcn_s_quadmask, amdgcn_s_wqm})
+ .Any({{B32}, {{SgprB32}, {IntrId, SgprB32_ReadFirstLane}}})
+ .Any({{B64}, {{SgprB64}, {IntrId, SgprB64_ReadFirstLane}}});
addRulesForIOpcs({amdgcn_writelane}, StandardB)
.Div(B32,
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td b/llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td
index 0968d7030578b..2f7f72bd58f0e 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPUSearchableTables.td
@@ -420,6 +420,8 @@ def : AlwaysUniform<int_amdgcn_s_getpc>;
def : AlwaysUniform<int_amdgcn_s_getreg>;
def : AlwaysUniform<int_amdgcn_s_memrealtime>;
def : AlwaysUniform<int_amdgcn_s_memtime>;
+def : AlwaysUniform<int_amdgcn_s_quadmask>;
+def : AlwaysUniform<int_amdgcn_s_wqm>;
def AMDGPUImageDMaskIntrinsicTable : GenericTable {
let FilterClass = "AMDGPUImageDMaskIntrinsic";
>From 760f5e8904853d7ba0abbd27dd19d6e790076877 Mon Sep 17 00:00:00 2001
From: Chinmay Deshpande <chdeshpa at amd.com>
Date: Tue, 9 Jun 2026 15:59:02 -0400
Subject: [PATCH 2/2] Adds tests, updates rules
---
.../AMDGPU/AMDGPURegBankLegalizeRules.cpp | 6 ++--
.../AMDGPU/always_uniform.ll | 32 +++++++++++++++++++
2 files changed, 35 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp b/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp
index 1a54b3f813c6b..b82561455167d 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeRules.cpp
@@ -1744,9 +1744,9 @@ RegBankLegalizeRules::RegBankLegalizeRules(const GCNSubtarget &_ST,
addRulesForIOpcs({amdgcn_readlane}, StandardB)
.Uni(B32, {{SgprB32}, {IntrId, VgprB32, SgprB32_ReadFirstLane}});
- addRulesForIOpcs({amdgcn_s_quadmask, amdgcn_s_wqm})
- .Any({{B32}, {{SgprB32}, {IntrId, SgprB32_ReadFirstLane}}})
- .Any({{B64}, {{SgprB64}, {IntrId, SgprB64_ReadFirstLane}}});
+ addRulesForIOpcs({amdgcn_s_quadmask, amdgcn_s_wqm}, StandardB)
+ .Uni(B32, {{SgprB32}, {IntrId, SgprB32_ReadFirstLane}})
+ .Uni(B64, {{SgprB64}, {IntrId, SgprB64_ReadFirstLane}});
addRulesForIOpcs({amdgcn_writelane}, StandardB)
.Div(B32,
diff --git a/llvm/test/Analysis/UniformityAnalysis/AMDGPU/always_uniform.ll b/llvm/test/Analysis/UniformityAnalysis/AMDGPU/always_uniform.ll
index 0fab1395ffc6e..6e75d4ead8cdd 100644
--- a/llvm/test/Analysis/UniformityAnalysis/AMDGPU/always_uniform.ll
+++ b/llvm/test/Analysis/UniformityAnalysis/AMDGPU/always_uniform.ll
@@ -119,6 +119,38 @@ define void @s_getreg(ptr addrspace(1) inreg %out) {
ret void
}
+; CHECK-LABEL: for function 's_quadmask_i32':
+; CHECK: DIVERGENT: i32 %mask
+; CHECK-NOT: DIVERGENT
+define i32 @s_quadmask_i32(i32 %mask) {
+ %result = call i32 @llvm.amdgcn.s.quadmask.i32(i32 %mask)
+ ret i32 %result
+}
+
+; CHECK-LABEL: for function 's_quadmask_i64':
+; CHECK: DIVERGENT: i64 %mask
+; CHECK-NOT: DIVERGENT
+define i64 @s_quadmask_i64(i64 %mask) {
+ %result = call i64 @llvm.amdgcn.s.quadmask.i64(i64 %mask)
+ ret i64 %result
+}
+
+; CHECK-LABEL: for function 's_wqm_i32':
+; CHECK: DIVERGENT: i32 %mask
+; CHECK-NOT: DIVERGENT
+define i32 @s_wqm_i32(i32 %mask) {
+ %result = call i32 @llvm.amdgcn.s.wqm.i32(i32 %mask)
+ ret i32 %result
+}
+
+; CHECK-LABEL: for function 's_wqm_i64':
+; CHECK: DIVERGENT: i64 %mask
+; CHECK-NOT: DIVERGENT
+define i64 @s_wqm_i64(i64 %mask) {
+ %result = call i64 @llvm.amdgcn.s.wqm.i64(i64 %mask)
+ ret i64 %result
+}
+
; CHECK-LABEL: for function 's_get_barrier_state':
; CHECK: DIVERGENT: i32 %bar
; CHECK-NOT: DIVERGENT
More information about the llvm-commits
mailing list