[llvm] [X86] Disallow immediate address calls when position independent (PR #202370)

[via llvm-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-x86

Author: agrieve

<details>
<summary>Changes</summary>

Causes problems with mold linker, and was determined to be a compiler bug. See:
See https://github.com/rui314/mold/pull/1601#issuecomment-4628653209

---
Full diff: https://github.com/llvm/llvm-project/pull/202370.diff


1 Files Affected:

- (modified) llvm/lib/Target/X86/X86Subtarget.cpp (+1-1) 


``````````diff
diff --git a/llvm/lib/Target/X86/X86Subtarget.cpp b/llvm/lib/Target/X86/X86Subtarget.cpp
index c576ba9e45506..5dbcb3ae2939b 100644
--- a/llvm/lib/Target/X86/X86Subtarget.cpp
+++ b/llvm/lib/Target/X86/X86Subtarget.cpp
@@ -241,7 +241,7 @@ bool X86Subtarget::isLegalToCallImmediateAddr() const {
   // FIXME: I386 PE/COFF supports PC relative calls using IMAGE_REL_I386_REL32
   // but WinCOFFObjectWriter::RecordRelocation cannot emit them.  Once it does,
   // the following check for Win32 should be removed.
-  if (Is64Bit || isTargetWin32())
+  if (Is64Bit || isTargetWin32() || isPositionIndependent())
     return false;
   return isTargetELF() || TM.getRelocationModel() == Reloc::Static;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/202370