[llvm] [X86] Disallow immediate address calls when position independent (PR #202370)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 8 08:45:04 PDT 2026
https://github.com/agrieve created https://github.com/llvm/llvm-project/pull/202370
Causes problems with mold linker, and was determined to be a compiler bug. See:
See https://github.com/rui314/mold/pull/1601#issuecomment-4628653209
>From d00d078611d2cf8e92f5083884e9ef4252372660 Mon Sep 17 00:00:00 2001
From: Andrew Grieve <agrieve at chromium.org>
Date: Mon, 8 Jun 2026 11:42:27 -0400
Subject: [PATCH] [X86] Disallow immediate address calls when position
independent
---
llvm/lib/Target/X86/X86Subtarget.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/lib/Target/X86/X86Subtarget.cpp b/llvm/lib/Target/X86/X86Subtarget.cpp
index c576ba9e45506..5dbcb3ae2939b 100644
--- a/llvm/lib/Target/X86/X86Subtarget.cpp
+++ b/llvm/lib/Target/X86/X86Subtarget.cpp
@@ -241,7 +241,7 @@ bool X86Subtarget::isLegalToCallImmediateAddr() const {
// FIXME: I386 PE/COFF supports PC relative calls using IMAGE_REL_I386_REL32
// but WinCOFFObjectWriter::RecordRelocation cannot emit them. Once it does,
// the following check for Win32 should be removed.
- if (Is64Bit || isTargetWin32())
+ if (Is64Bit || isTargetWin32() || isPositionIndependent())
return false;
return isTargetELF() || TM.getRelocationModel() == Reloc::Static;
}
More information about the llvm-commits
mailing list