[llvm] Revert "[Lit] Open sub-processes with text=`False`" (PR #196329)
via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 07:34:14 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-testing-tools
Author: Benjamin Stott (BStott6)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->194577 due to breaking tests on z/OS
---
Full diff: https://github.com/llvm/llvm-project/pull/196329.diff
1 Files Affected:
- (modified) llvm/utils/lit/lit/TestRunner.py (+2-1)
``````````diff
diff --git a/llvm/utils/lit/lit/TestRunner.py b/llvm/utils/lit/lit/TestRunner.py
index 743f7bcccd533..51dfe3b6c5157 100644
--- a/llvm/utils/lit/lit/TestRunner.py
+++ b/llvm/utils/lit/lit/TestRunner.py
@@ -475,7 +475,8 @@ def _executeShCmd(cmd, shenv, results, timeoutHelper):
stderr=stderr,
env=cmd_shenv.env,
close_fds=kUseCloseFDs,
- text=False,
+ universal_newlines=True,
+ errors="replace",
)
)
if old_umask != -1:
``````````
</details>
https://github.com/llvm/llvm-project/pull/196329
More information about the llvm-commits
mailing list