[llvm] Revert "[Lit] Open sub-processes with text=`False`" (PR #196329)
Benjamin Stott via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 07:33:11 PDT 2026
https://github.com/BStott6 created https://github.com/llvm/llvm-project/pull/196329
Reverts llvm/llvm-project#194577 due to breaking tests on z/OS
>From 24db39e60eb38f7c9691ff4e2f6be671e4e79c03 Mon Sep 17 00:00:00 2001
From: Benjamin Stott <Benjamin.Stott at sony.com>
Date: Thu, 7 May 2026 15:32:45 +0100
Subject: [PATCH] Revert "[Lit] Open sub-processes with text=`False` (#194577)"
This reverts commit 7ceac4b1af614c886760b6d1d10d523d910c86d3.
---
llvm/utils/lit/lit/TestRunner.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/llvm/utils/lit/lit/TestRunner.py b/llvm/utils/lit/lit/TestRunner.py
index 743f7bcccd533..51dfe3b6c5157 100644
--- a/llvm/utils/lit/lit/TestRunner.py
+++ b/llvm/utils/lit/lit/TestRunner.py
@@ -475,7 +475,8 @@ def _executeShCmd(cmd, shenv, results, timeoutHelper):
stderr=stderr,
env=cmd_shenv.env,
close_fds=kUseCloseFDs,
- text=False,
+ universal_newlines=True,
+ errors="replace",
)
)
if old_umask != -1:
More information about the llvm-commits
mailing list