[compiler-rt] [NFCI] clarify that asan-*linux.cpp files affect *nix OS'es (PR #195565)
David Justo via llvm-commits
llvm-commits at lists.llvm.org
Mon May 4 09:26:29 PDT 2026
================
@@ -8,7 +8,7 @@
//
// This file is a part of AddressSanitizer, an address sanity checker.
//
-// Linux-specific malloc interception.
+// Linux-specific (and Unix/Unix-like) malloc interception.
----------------
davidmrdavid wrote:
Thanks! I agree in principle that this is redundant, but I'd like to keep this as-is for now for the reasons I explain here: https://github.com/llvm/llvm-project/pull/195565#discussion_r3179097762
In short - there's a pending discussion to be had about how to name these files (clearly, `*_linux.cpp` is a misleading name). As such, I'm trying to make this PR strictly additive (thus the redundancy) to circumvent forcing that discussion, which would unnecessarily delay this small documentation improvement.
Here's my suggestion - assuming this gets merged, I'm happy to start a discourse on how we want to name these files (they're not linux specific, like the name implies) and based on that resolution (which may take a bit) I'm happy to assist in the renaming and clean up this comment. Would that suffice? Thanks!
https://github.com/llvm/llvm-project/pull/195565
More information about the llvm-commits
mailing list