[clang] [llvm] Compute GUIDs once and store in metadata (PR #184065)

Owen Rodley via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 21:57:48 PDT 2026


================
@@ -7304,9 +7280,13 @@ ModuleSummaryIndexBitcodeReader::getValueInfoFromValueId(unsigned ValueId) {
 void ModuleSummaryIndexBitcodeReader::setValueGUID(
     uint64_t ValueID, StringRef ValueName, GlobalValue::LinkageTypes Linkage,
     StringRef SourceFileName) {
-  std::string GlobalId =
-      GlobalValue::getGlobalIdentifier(ValueName, Linkage, SourceFileName);
-  auto ValueGUID = GlobalValue::getGUIDAssumingExternalLinkage(GlobalId);
+  GlobalValue::GUID ValueGUID = 0;
+  if (ValueID < DefinedGUIDs.size())
+    ValueGUID = DefinedGUIDs[ValueID];
+  if (ValueGUID == 0)
----------------
orodley wrote:

Ran the tests with an `else` instead, and yes this does seem to break things. 

https://github.com/llvm/llvm-project/pull/184065


More information about the llvm-commits mailing list