[llvm] [SPIR-V] Handle constant expression uses of PushConstant globals (PR #193005)

via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 08:46:45 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/SPIRV/SPIRVPushConstantAccess.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVPushConstantAccess.cpp b/llvm/lib/Target/SPIRV/SPIRVPushConstantAccess.cpp
index 98d86fb1f..31e69a49a 100644
--- a/llvm/lib/Target/SPIRV/SPIRVPushConstantAccess.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVPushConstantAccess.cpp
@@ -36,7 +36,8 @@ static bool replacePushConstantAccesses(Module &M, SPIRVGlobalRegistry *GR) {
         storageClassToAddressSpace(SPIRV::StorageClass::PushConstant))
       continue;
 
-    convertUsersOfConstantsToInstructions(llvm::SmallVector<Constant *, 1>(1, &GV));
+    convertUsersOfConstantsToInstructions(
+        llvm::SmallVector<Constant *, 1>(1, &GV));
 
     Type *PCType = llvm::TargetExtType::get(
         M.getContext(), "spirv.PushConstant", {GV.getValueType()});

``````````

</details>


https://github.com/llvm/llvm-project/pull/193005


More information about the llvm-commits mailing list