[llvm] [VPlan] Fix isLatch to handle BranchOnTwoConds, check verifier.(NFC) (PR #192808)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 100324 tests passed
* 2154 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.o</summary>

```
FAILED: unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.o
sccache /opt/llvm/bin/clang++ -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/unittests/Transforms/Vectorize -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Transforms/Vectorize -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googlemock/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -UNDEBUG -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -Wno-suggest-override -MD -MT unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.o -MF unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.o.d -o unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp:485:71: error: too few arguments to function call, expected 6, have 2
485 |   VPlanTransforms::handleEarlyExits(*Plan, /*HasUncountableExit=*/true);
|   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                   ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/../lib/Transforms/Vectorize/VPlanTransforms.h:157:3: note: 'handleEarlyExits' declared here
157 |   handleEarlyExits(VPlan &Plan, UncountableExitStyle Style, Loop *TheLoop,
|   ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
158 |                    PredicatedScalarEvolution &PSE, DominatorTree &DT,
|                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
159 |                    AssumptionCache *AC);
|                    ~~~~~~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/unittests/Transforms/Vectorize/VPlanVerifierTest.cpp:487:50: error: too many arguments to function call, expected 2, have 3
486 |   VPlanTransforms::addMiddleCheck(*Plan, /*RequiresScalarEpilogueCheck=*/true,
|   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
487 |                                   /*TailFolded=*/false);
|                                                  ^~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/../lib/Transforms/Vectorize/VPlanTransforms.h:163:33: note: 'addMiddleCheck' declared here
163 |   LLVM_ABI_FOR_TEST static void addMiddleCheck(VPlan &Plan, bool TailFolded);
|                                 ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/192808