[llvm] [VPlan] Fix isLatch to handle BranchOnTwoConds, check verifier.(NFC) (PR #192808)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 61546 tests passed
* 1599 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.obj</summary>

```
FAILED: [code=1] unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\unittests\Transforms\Vectorize -IC:\_work\llvm-project\llvm-project\llvm\unittests\Transforms\Vectorize -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- -Wno-suggest-override /showIncludes /Founittests\Transforms\Vectorize\CMakeFiles\VectorizeTests.dir\VPlanVerifierTest.cpp.obj /Fdunittests\Transforms\Vectorize\CMakeFiles\VectorizeTests.dir\ -c -- C:\_work\llvm-project\llvm-project\llvm\unittests\Transforms\Vectorize\VPlanVerifierTest.cpp
C:\_work\llvm-project\llvm-project\llvm\unittests\Transforms\Vectorize\VPlanVerifierTest.cpp(485,71): error: too few arguments to function call, expected 6, have 2
485 |   VPlanTransforms::handleEarlyExits(*Plan, /*HasUncountableExit=*/true);
|   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                   ^
C:\_work\llvm-project\llvm-project\llvm\include\../lib/Transforms/Vectorize/VPlanTransforms.h(157,3): note: 'handleEarlyExits' declared here
157 |   handleEarlyExits(VPlan &Plan, UncountableExitStyle Style, Loop *TheLoop,
|   ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
158 |                    PredicatedScalarEvolution &PSE, DominatorTree &DT,
|                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
159 |                    AssumptionCache *AC);
|                    ~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\unittests\Transforms\Vectorize\VPlanVerifierTest.cpp(487,50): error: too many arguments to function call, expected 2, have 3
486 |   VPlanTransforms::addMiddleCheck(*Plan, /*RequiresScalarEpilogueCheck=*/true,
|   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
487 |                                   /*TailFolded=*/false);
|                                                  ^~~~~
C:\_work\llvm-project\llvm-project\llvm\include\../lib/Transforms/Vectorize/VPlanTransforms.h(163,33): note: 'addMiddleCheck' declared here
163 |   LLVM_ABI_FOR_TEST static void addMiddleCheck(VPlan &Plan, bool TailFolded);
|                                 ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/192808