[llvm] [llvm-readobj][ELF] Remove redundant error in reportWarning (PR #192458)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 16 06:55:54 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-binary-utilities
Author: aokblast
<details>
<summary>Changes</summary>
If MapOrError contains no error, calling takeError() results in undefined behavior and may crash the program.
---
Full diff: https://github.com/llvm/llvm-project/pull/192458.diff
1 Files Affected:
- (modified) llvm/tools/llvm-readobj/ELFDumper.cpp (+1-2)
``````````diff
diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index bcb580119fb85..bfe1f89c1493d 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -8245,8 +8245,7 @@ template <class ELFT> void LLVMELFDumper<ELFT>::printCallGraphInfo() {
return;
}
if (MapOrErr->empty()) {
- reportWarning(createError("no SHT_LLVM_CALL_GRAPH section found" +
- toString(MapOrErr.takeError())),
+ reportWarning(createError("no SHT_LLVM_CALL_GRAPH section found"),
this->FileName);
return;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/192458
More information about the llvm-commits
mailing list