[llvm] [llvm-readobj][ELF] Remove redundant error in reportWarning (PR #192458)

via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 06:55:15 PDT 2026


https://github.com/aokblast created https://github.com/llvm/llvm-project/pull/192458

If MapOrError contains no error, calling takeError() results in undefined behavior and may crash the program.

>From 97b215ee87bc6682ae8c1c321d568bc71b16ba76 Mon Sep 17 00:00:00 2001
From: ShengYi Hung <aokblast at FreeBSD.org>
Date: Thu, 16 Apr 2026 21:50:34 +0800
Subject: [PATCH] [llvm-readobj][ELF] Remove redundant error in reportWarning

If MapOrError contains no error, calling takeError() results in
undefined behavior and may crash the program.
---
 llvm/tools/llvm-readobj/ELFDumper.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index bcb580119fb85..bfe1f89c1493d 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -8245,8 +8245,7 @@ template <class ELFT> void LLVMELFDumper<ELFT>::printCallGraphInfo() {
     return;
   }
   if (MapOrErr->empty()) {
-    reportWarning(createError("no SHT_LLVM_CALL_GRAPH section found" +
-                              toString(MapOrErr.takeError())),
+    reportWarning(createError("no SHT_LLVM_CALL_GRAPH section found"),
                   this->FileName);
     return;
   }



More information about the llvm-commits mailing list