[lld] [LLD] [COFF] Remove a now incorrect comment in a test. NFC. (PR #190489)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 4 14:12:35 PDT 2026


https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/190489

This comment was added in 26572002749ee2e7d734e4e0aed4cca0e1c623c3 in 2018. Later in 8f540dad6120d00e3ad896b98cd32bcf00623ccd in 2020, the LLVM MC layer was adjusted to do essentially the same as GNU binutils do.

Therefore, I think that this test now technically could be done with object files generated by llvm-mc as well, instead of bundled binary object files.

>From aa6515b158595d05baa1a9389267e3682f6c4391 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin at martin.st>
Date: Sat, 4 Apr 2026 14:44:32 +0300
Subject: [PATCH] [LLD] [COFF] Remove a now incorrect comment in a test. NFC.

This comment was added in 26572002749ee2e7d734e4e0aed4cca0e1c623c3
in 2018. Later in 8f540dad6120d00e3ad896b98cd32bcf00623ccd in
2020, the LLVM MC layer was adjusted to do essentially the same
as GNU binutils do.

Therefore, I think that this test now technically could be done
with object files generated by llvm-mc as well, instead of
bundled binary object files.
---
 lld/test/COFF/gnu-weak.test | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lld/test/COFF/gnu-weak.test b/lld/test/COFF/gnu-weak.test
index 08e59734e0424..8e900eaa7e090 100644
--- a/lld/test/COFF/gnu-weak.test
+++ b/lld/test/COFF/gnu-weak.test
@@ -13,9 +13,6 @@ For each of the weak definitions, GNU tools produce a regular symbol
 named .weak.<weaksymbol>.<othersymbol>, where the other symbol name is
 another symbol defined close by.
 
-This can't be reproduced by assembling with llvm-mc, as llvm-mc always
-produces similar regular symbols named .weak.<weaksymbol>.default.
-
 The bundled object files can be produced from test code that looks like
 this:
 



More information about the llvm-commits mailing list