[llvm] [LoopUnroll] Remove `computeUnrollCount()`'s return value (PR #184529)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopUnrollPass.cpp.obj</summary>

```
FAILED: [code=1] lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopUnrollPass.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\lib\Transforms\Scalar -IC:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Folib\Transforms\Scalar\CMakeFiles\LLVMScalarOpts.dir\LoopUnrollPass.cpp.obj /Fdlib\Transforms\Scalar\CMakeFiles\LLVMScalarOpts.dir\LLVMScalarOpts.pdb -c -- C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(766,10): error: call to 'getUnrollMetadataForLoop' is ambiguous
766 |   return getUnrollMetadataForLoop(L, "llvm.loop.unroll.full");
|          ^~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(125,18): note: candidate function
125 | LLVM_ABI MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name);
|                  ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(758,16): note: candidate function
758 | static MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name) {
|                ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(772,10): error: call to 'getUnrollMetadataForLoop' is ambiguous
772 |   return getUnrollMetadataForLoop(L, "llvm.loop.unroll.enable");
|          ^~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(125,18): note: candidate function
125 | LLVM_ABI MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name);
|                  ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(758,16): note: candidate function
758 | static MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name) {
|                ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(777,10): error: call to 'getUnrollMetadataForLoop' is ambiguous
777 |   return getUnrollMetadataForLoop(L, "llvm.loop.unroll.runtime.disable");
|          ^~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(125,18): note: candidate function
125 | LLVM_ABI MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name);
|                  ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(758,16): note: candidate function
758 | static MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name) {
|                ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(783,16): error: call to 'getUnrollMetadataForLoop' is ambiguous
783 |   MDNode *MD = getUnrollMetadataForLoop(L, "llvm.loop.unroll.count");
|                ^~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(125,18): note: candidate function
125 | LLVM_ABI MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name);
|                  ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(758,16): note: candidate function
758 | static MDNode *getUnrollMetadataForLoop(const Loop *L, StringRef Name) {
|                ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(797,24): error: call to 'hasUnrollFullPragma' is ambiguous
797 |       PragmaFullUnroll(hasUnrollFullPragma(L)),
|                        ^~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(128,15): note: candidate function
128 | LLVM_ABI bool hasUnrollFullPragma(const Loop *L);
|               ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(765,13): note: candidate function
765 | static bool hasUnrollFullPragma(const Loop *L) {
|             ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(798,19): error: call to 'unrollCountPragmaValue' is ambiguous
798 |       PragmaCount(unrollCountPragmaValue(L)),
|                   ^~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(139,19): note: candidate function
139 | LLVM_ABI unsigned unrollCountPragmaValue(const Loop *L);
|                   ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(782,17): note: candidate function
782 | static unsigned unrollCountPragmaValue(const Loop *L) {
|                 ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(799,26): error: call to 'hasUnrollEnablePragma' is ambiguous
799 |       PragmaEnableUnroll(hasUnrollEnablePragma(L)),
|                          ^~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Transforms/Utils/UnrollLoop.h(132,15): note: candidate function
132 | LLVM_ABI bool hasUnrollEnablePragma(const Loop *L);
|               ^
C:\_work\llvm-project\llvm-project\llvm\lib\Transforms\Scalar\LoopUnrollPass.cpp(771,13): note: candidate function
771 | static bool hasUnrollEnablePragma(const Loop *L) {
|             ^
7 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/184529