[flang] [llvm] [flang] Implement SPLIT intrinsic subroutine with tests (PR #185584)

[Tarun Prabhu via llvm-commits]

================
@@ -8538,6 +8545,39 @@ void IntrinsicLibrary::genSleep(llvm::ArrayRef<fir::ExtendedValue> args) {
   fir::runtime::genSleep(builder, loc, fir::getBase(args[0]));
 }
 
+// SPLIT
+void IntrinsicLibrary::genSplit(llvm::ArrayRef<fir::ExtendedValue> args) {
+  assert(args.size() == 4 && "SPLIT requires 3 or 4 arguments");
----------------
tarunprabhu wrote:

Sorry, didn't notice this before. This comment is confusing because it says that SPLIT requires "3 or 4" arguments, but the assertion is checking for exactly 4. The use of explanatory strings in this file is inconsistent anyway. Not having one may be ok.

https://github.com/llvm/llvm-project/pull/185584