[llvm] [OFFLOAD] Generalize support for OffloadBinary images (PR #186088)

Alex Duran via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 07:43:10 PDT 2026


================
@@ -2383,8 +2383,8 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
 
   /// Load the binary image into the device and allocate an image object.
   Expected<DeviceImageTy *>
-  loadBinaryImpl(std::unique_ptr<MemoryBuffer> &&TgtImage,
-                 int32_t ImageId) override {
+  loadBinaryImpl(std::unique_ptr<MemoryBuffer> &&TgtImage, int32_t ImageId,
----------------
adurang wrote:

The Id is passed around in case some layer decides to use it... I think we use it to print messages sometimes. 
It's just a sequence in the loaded order. It doesn't matter if they're nested or not. But I didn't check this carefully, so i'll do that again.

https://github.com/llvm/llvm-project/pull/186088


More information about the llvm-commits mailing list