[llvm] 61c237b - github-automation.py: Avoid duplicate pings (#184321)

via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 04:05:08 PDT 2026


Author: Kleis Auke Wolthuizen
Date: 2026-03-11T11:05:02Z
New Revision: 61c237b837f7c78a443f348257685071886178ec

URL: https://github.com/llvm/llvm-project/commit/61c237b837f7c78a443f348257685071886178ec
DIFF: https://github.com/llvm/llvm-project/commit/61c237b837f7c78a443f348257685071886178ec.diff

LOG: github-automation.py: Avoid duplicate pings (#184321)

Follow-up to: #149653.

As noticed in:
https://github.com/llvm/llvm-project/pull/184288#issuecomment-3988440497.

Added: 
    

Modified: 
    llvm/utils/git/github-automation.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 2f4f805023bad..57a4e45201a84 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -673,7 +673,10 @@ def pr_request_review(self, pr: github.PullRequest.PullRequest):
                 for review in pull.get_reviews():
                     if review.state != "APPROVED":
                         continue
-                    reviewers.append(review.user.login)
+                    # Ensure the reviewer list contains only unique entries, as
+                    # reviewers may have submitted more than one round of review.
+                    if review.user.login not in reviewers:
+                        reviewers.append(review.user.login)
         if len(reviewers):
             message = "{} What do you think about merging this PR to the release branch?".format(
                 " ".join(["@" + r for r in reviewers])


        


More information about the llvm-commits mailing list