[llvm] [AMDGPU][SIInsertWaitcnts][NFC] Drop MaxCounter member variable (PR #181092)

[Pierre van Houtryve via llvm-commits]

https://github.com/Pierre-vh requested changes to this pull request.

I agree with Sameer that this doesn't seem like a positive change. It's a constant, calling a function makes the flow more complex than it has to be.

If you really want to simplify this, I think a better way is to move code around so it's all initialized in one clear place. For example, remove that `MaxCounter` argument and just call the new function once from the constructor, instead of requiring a function call every time we want to access this constant value

https://github.com/llvm/llvm-project/pull/181092