[llvm] [LLVM][Verifier] Improve diagnostic messages for Intrinsics in Verifier (PR #185641)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 132046 tests passed
* 2991 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### LLVM
<details>
<summary>LLVM.CodeGen/NVPTX/sad-intrins-invalid.ll</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
split-file C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\NVPTX\sad-intrins-invalid.ll C:\_work\llvm-project\llvm-project\build\test\CodeGen\NVPTX\Output\sad-intrins-invalid.ll.tmp
# executed command: split-file 'C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\NVPTX\sad-intrins-invalid.ll' 'C:\_work\llvm-project\llvm-project\build\test\CodeGen\NVPTX\Output\sad-intrins-invalid.ll.tmp'
# note: command had no output on stdout or stderr
# RUN: at line 2
not c:\_work\llvm-project\llvm-project\build\bin\llc.exe -mtriple=nvptx64 -mcpu=sm_50 < C:\_work\llvm-project\llvm-project\build\test\CodeGen\NVPTX\Output\sad-intrins-invalid.ll.tmp/main.ll 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\NVPTX\sad-intrins-invalid.ll
# executed command: not 'c:\_work\llvm-project\llvm-project\build\bin\llc.exe' -mtriple=nvptx64 -mcpu=sm_50
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\NVPTX\sad-intrins-invalid.ll'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\NVPTX\sad-intrins-invalid.ll:8:15: error: CHECK-NEXT: expected string not found in input
# | ; CHECK-NEXT: declared return type is 'i16', expected 'i32' in canonical signature 'i32 (i32, i32, i32)'
# |               ^
# | <stdin>:1:37: note: scanning from here
# | Intrinsic has incorrect return type!
# |                                     ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\llvm\test\CodeGen\NVPTX\sad-intrins-invalid.ll
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |         1: Intrinsic has incorrect return type! 
# | next:8                                         X error: no match found
# |         2: ptr @llvm.nvvm.sad.i 
# | next:8     ~~~~~~~~~~~~~~~~~~~~~
# |         3: Intrinsic called with incompatible signature 
# | next:8     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |         4:  %1 = call i32 @llvm.nvvm.sad.ui(i32 %x, i32 %y, i16 %z) 
# | next:8     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |         5: Intrinsic called with incompatible signature 
# | next:8     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |         6:  %1 = call i64 @llvm.nvvm.sad.ull(i64 %x, i64 %y, i64 %z, i64 %w) 
# | next:8     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |         .
# |         .
# |         .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/185641