[llvm] [DebugInfo][AT] Treat escaping calls as untagged stores in assignment tracking (PR #183979)
Shivam Kunwar via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 10 05:05:39 PDT 2026
phyBrackets wrote:
> Thanks. I think the new test is valuable to keep, but isn't quite what I meant. Essentially I wanted to see a test that showed a address-modifying DIExpression (the 2nd DIExpression in the dbg_assign) is correctly applied. But seeing the old TODO list and looking at the code again I can see that case isn't yet handled in other places in this pass either - so there's nothing you need to do for that after all.
>
> Instead please could you add an assert like [this one](https://github.com/llvm/llvm-project/blob/9b1aadd23324dd163541aa9c452ed700b699dd65/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp#L2394), so it's easy to find this site in future if/when that TODO is addressed?
>
> Thanks for working on this
Thanks @OCHyams , that makes sense, I've added the assert on the address expression being empty, with a TODO comment pointing to the same pattern. Thanks for your review!
https://github.com/llvm/llvm-project/pull/183979
More information about the llvm-commits
mailing list